Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Panning Example #15

Merged
merged 1 commit into from Oct 6, 2021
Merged

Sound Panning Example #15

merged 1 commit into from Oct 6, 2021

Conversation

FlexYourBrain
Copy link
Contributor

Completed sound panning example ready for pull request.

Completed sound panning example ready for pull request.
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What is the source of the coin image? Perhaps we could use the coin from this Kenney asset pack instead? https://kenney.nl/assets/jumper-pack

@FlexYourBrain
Copy link
Contributor Author

FlexYourBrain commented Oct 6, 2021

The source of the coin image is my work, I create all of my assets myself from scratch ,including the coin sound. I can create something similar Kenney's work if that would fit better. I am guessing a single image would be better for the site keeping more room in the atlas?

@britzl britzl merged commit 2572627 into defold:master Oct 6, 2021
@britzl
Copy link
Contributor

britzl commented Oct 6, 2021

Thanks. Since it is your image and sound there's no problem merging the contribution!

@FlexYourBrain
Copy link
Contributor Author

Thank you britzl , I created new coins anyway that I believe are better suited for the example and are more likely to be used in possible future examples submissions. Created a new pull request for the small changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants