Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aapt2 to compile android resources and generate R.java files #177

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

britzl
Copy link
Contributor

@britzl britzl commented Sep 26, 2020

This will allow us to send back the compiled resources to the client for use in the AAB build while at the same time getting R.java files with resource ids exactly matching the generated resources.

@@ -0,0 +1,59 @@
package com.defold.extender;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was useful while testing to quickly get an overview of the folder structure when processing or building android packages. We can remove it and I'll put it in a gist for future use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to have here.
Fyi, I generally use the tree command on the command line.
(I.e. not deleting the job folder, then logging into the server)

@britzl britzl requested a review from JCash September 27, 2020 12:45
Comment on lines +757 to +761
private Map<String, Object> createContext() throws ExtenderException {
HashMap<String, Object> empty = new HashMap<>();
Map<String, Object> context = context(empty);
return context;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did this in a lot of places. Might as well move it to a small helper function


return files;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the android functions (later) to an android specific module, since the Extender.java is really starting to be quite large.

@@ -0,0 +1,59 @@
package com.defold.extender;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to have here.
Fyi, I generally use the tree command on the command line.
(I.e. not deleting the job folder, then logging into the server)

@JCash JCash merged commit 28c326f into dev Sep 28, 2020
@JCash JCash deleted the dev-aapt2 branch September 28, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants