Reduce big memory allocations when sending and receiving data from a remote builder #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britzl
commented
Oct 11, 2021
| @@ -186,10 +186,8 @@ public void buildEngine(HttpServletRequest request, | |||
| if (remoteBuilderEnabled && isRemotePlatform(platform)) { | |||
| LOGGER.info("Building engine on remote builder"); | |||
|
|
|||
| final byte[] bytes = remoteEngineBuilder.build(uploadDirectory, platform, sdkVersion); | |||
| remoteEngineBuilder.build(uploadDirectory, platform, sdkVersion, response.getOutputStream()); | |||
There was a problem hiding this comment.
The final output of a build is supposed to go to the response.getOutputStream() so we might as well pass that to the remote engine builder.
britzl
commented
Oct 11, 2021
| response.getEntity().writeTo(bos); | ||
|
|
||
| final byte[] bytes = bos.toByteArray(); | ||
| response.getEntity().writeTo(out); |
There was a problem hiding this comment.
Write the response directly to the output stream without first reading all of the bytes into a byte array
britzl
commented
Oct 11, 2021
| } catch (IOException e) { | ||
| throw new IllegalStateException(e); | ||
| } | ||
| AbstractContentBody body = new FileBody(path.toFile(), ContentType.DEFAULT_BINARY, relativePath); |
There was a problem hiding this comment.
Don't read the all of the bytes from each file. Add each file directly to the multi part request builder (and hopefully the underlying implementation is clever enough to read the bytes sequentially as they are sent over the wire).
JCash
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.