Fixed missing remote build errors #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britzl
approved these changes
Oct 14, 2021
JCash
commented
Oct 14, 2021
| if (isClientError(response)) { | ||
| throw new ExtenderException("Client error when building engine remotely: " + getStatusReason(response)); | ||
| String error = getErrorString(response); | ||
| LOGGER.error("Client error when building engine remotely:\n{}", error); |
There was a problem hiding this comment.
We want to return the actual error message.
The status is just a protocol for use to determine what type of error the remote server produced: build error (ok) or server error (not ok)
In the case of a build error, we want to attach the message to the exception that is passed upwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.