Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux update #217

Merged
merged 19 commits into from
Dec 27, 2021
Merged

Linux update #217

merged 19 commits into from
Dec 27, 2021

Conversation

JCash
Copy link
Contributor

@JCash JCash commented Dec 14, 2021

Current status:

  • Using Geadle 6.9, as our gradle docker build plugin doesn't support 7.x
  • Extender jar file now became two files by default, had to do some tricks to get a fat jar
  • Spring server won't start properly, complaining about "No auto configuration classes found in META-INF/spring.factories"

Untested container functionality:

  • Updated to Java 17, how will Android builds go?
  • Only installed winetricks, without vcrun2015 (i.e. vc_redist). How willwin32/switch builds go?
  • Using clang 13, how will iOS builds go?

@JCash JCash linked an issue Dec 14, 2021 that may be closed by this pull request
@JCash JCash removed a link to an issue Dec 17, 2021
@JCash JCash linked an issue Dec 17, 2021 that may be closed by this pull request
@JCash
Copy link
Contributor Author

JCash commented Dec 17, 2021

Downgraded back to OpenJDK 11 due to issues with using Gradle 6.1.1 (in the container)
I tried updating to Gradle 6.9.1, but it seems something (groovy) is locked to version 6.1.
I'm wondering if it's something to do with the Android sdk?

java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.vmplugin.v7.Java7

@britzl
Copy link
Contributor

britzl commented Dec 17, 2021

I tried updating to Gradle 6.9.1, but it seems something (groovy) is locked to version 6.1.
I'm wondering if it's something to do with the Android sdk?

Yes, probably. We use Android Gradle Plugin version 4.0.1 (see template.build_gradle) and it depends on a specific Gradle version:

https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#updating-gradle

(Also see note on JDK version on the same page)

@JCash
Copy link
Contributor Author

JCash commented Dec 17, 2021

I'm assuming you meant build_gradle.template?

@britzl
Copy link
Contributor

britzl commented Dec 17, 2021

I'm assuming you meant build_gradle.template?

No, I meant this file: https://github.com/defold/extender/blob/dev/server/docker-base/template.build.gradle

@JCash
Copy link
Contributor Author

JCash commented Dec 17, 2021

The branch now builds locally, and needs to be tested more thoroughly.
E.g. as the stand along server.

Other changes:
Removed support for Emscripten 1.3.16 (we use 2.0.11 since 1.2.178)

@JCash JCash linked an issue Dec 17, 2021 that may be closed by this pull request
@JCash JCash removed a link to an issue Dec 17, 2021
@JCash JCash requested a review from britzl December 27, 2021 09:01
@JCash JCash merged commit 9d794d9 into dev Dec 27, 2021
@JCash JCash deleted the linux-update branch December 27, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Ubuntu 20
2 participants