Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency duplication. Now extender start inside Jetty not inside Tomcat. #226

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented Apr 1, 2022

Because of dependency duplication extender starts inside Apache Tomcat, not inside Eclipse Jetty. These bug was introduced when spring boot were updated (38d045b).
These fix remove dependency duplication. Now extender runs inside Jetty.

@britzl britzl requested review from JCash and britzl April 2, 2022 09:51
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good find! We specifically try to catch a Jetty EOFException in the extender controller and I guess it won't happen if we're running in Tomcat and not Jetty :-)

@britzl britzl merged commit d611585 into defold:dev Apr 6, 2022
AGulev added a commit that referenced this pull request Apr 8, 2022
AGulev added a commit that referenced this pull request Apr 11, 2022
…ide Jetty not inside Tomcat. (#226)""

This reverts commit 151333e.
@ekharkunov ekharkunov deleted the fix-embedded-container-dependency branch January 24, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants