Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune libraries the same way as the main engine linking is doing #233

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

JCash
Copy link
Contributor

@JCash JCash commented Jun 21, 2022

No description provided.

@JCash JCash requested a review from AGulev June 21, 2022 09:33
Comment on lines +523 to +526
context.put("engineLibs", ExtenderUtil.pruneItems(ExtenderUtil.getStringList(context, "engineLibs"), ExtenderUtil.getStringList(context, "includeLibs"), ExtenderUtil.getStringList(context, "excludeLibs")) );
context.put("engineJsLibs", ExtenderUtil.pruneItems(ExtenderUtil.getStringList(context, "engineJsLibs"), ExtenderUtil.getStringList(context, "includeJsLibs"), ExtenderUtil.getStringList(context, "excludeJsLibs")) );
context.put("objectFiles", ExtenderUtil.pruneItems(ExtenderUtil.getStringList(context, "objectFiles"), ExtenderUtil.getStringList(context, "includeObjectFiles"), ExtenderUtil.getStringList(context, "excludeObjectFiles") ));
context.put("dynamicLibs", ExtenderUtil.pruneItems(ExtenderUtil.getStringList(context, "dynamicLibs"), ExtenderUtil.getStringList(context, "includeDynamicLibs"), ExtenderUtil.getStringList(context, "excludeDynamicLibs")) );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same way that the engine linker does it.

My dream is to simplify all these things a lot, but I still haven't found the time to do it yet.

Copy link
Contributor

@AGulev AGulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
how it's specified on the bob.jar side when you build lib? just as an app.manifest in project?

@JCash
Copy link
Contributor Author

JCash commented Jun 21, 2022

You specify "--build-artifacts=plugins" to bob (and also the variant):
https://github.com/defold/extension-spine/blob/main/utils/build_plugins.sh#L76

@JCash
Copy link
Contributor Author

JCash commented Jun 21, 2022

It it possibble to specify an app manifest as well, by passing in a custom .ini file which specifies an app manifest.
I didn't do it in this case though.

@JCash JCash merged commit a3ba8b2 into dev Jun 21, 2022
@JCash JCash deleted the library-manifest-merge-fix branch June 21, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants