-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up setup instructions #234
Conversation
|
||
* Build the Extender Docker image by running: | ||
NOTE: If you only plan to use the extender server to build for a single platform you may remove the setup steps for the other platforms to speed up the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only speed up? If the any platforms are missing, the Dockerfile won't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant was not to ignore those steps but to remove them. For instance removing everything related to Emscripten (https://github.com/defold/extender/blob/dev/server/docker-base/Dockerfile#L73-L110) from the Docketfile would mean that Emscripten isn't included in the image and you won't be able to build anything for HTML5 right?
|
||
$ TARGET_DIR=/path/to/localextender ./server/scripts/run-standalone-local.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the prerequisites here in terms of package availability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! It should be what we have in the Dockerfile right?
ENV XCODE_13_VERSION 13.2.1
ENV MACOS_12_VERSION 12.1
ENV IOS_15_VERSION 15.2
ENV XCODE_13_CLANG_VERSION 13.0.0
ENV SWIFT_5_5_VERSION 5.5
## Submodule setup | ||
Make sure you have initialized and fetched submodules: | ||
|
||
``` | ||
git submodule init | ||
git submodule update | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this step is optional for some (external) users?
Made it clearer for an external developer how to set up and run extender locally