Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up setup instructions #234

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Cleaned up setup instructions #234

merged 2 commits into from
Jun 28, 2022

Conversation

britzl
Copy link
Contributor

@britzl britzl commented Jun 26, 2022

Made it clearer for an external developer how to set up and run extender locally

@britzl britzl requested a review from JCash June 26, 2022 07:24

* Build the Extender Docker image by running:
NOTE: If you only plan to use the extender server to build for a single platform you may remove the setup steps for the other platforms to speed up the build process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only speed up? If the any platforms are missing, the Dockerfile won't work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was not to ignore those steps but to remove them. For instance removing everything related to Emscripten (https://github.com/defold/extender/blob/dev/server/docker-base/Dockerfile#L73-L110) from the Docketfile would mean that Emscripten isn't included in the image and you won't be able to build anything for HTML5 right?


$ TARGET_DIR=/path/to/localextender ./server/scripts/run-standalone-local.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the prerequisites here in terms of package availability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! It should be what we have in the Dockerfile right?

ENV XCODE_13_VERSION 13.2.1
ENV MACOS_12_VERSION 12.1
ENV IOS_15_VERSION 15.2
ENV XCODE_13_CLANG_VERSION 13.0.0
ENV SWIFT_5_5_VERSION 5.5

Comment on lines +10 to +16
## Submodule setup
Make sure you have initialized and fetched submodules:

```
git submodule init
git submodule update
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this step is optional for some (external) users?

@britzl britzl merged commit a27f6d2 into dev Jun 28, 2022
@britzl britzl deleted the dev-improved-setup-instructions branch June 28, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants