Add support for asynchronous extender builds #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build_async /job_status /job_result
JCash
approved these changes
Aug 26, 2022
Comment on lines
+83
to
+108
| task createVersionFile() { | ||
| def sha = System.getenv("COMMIT_SHORT_SHA") | ||
| if (sha == null) { | ||
| def outputStream = new ByteArrayOutputStream() | ||
| exec { | ||
| commandLine "git", "rev-parse", "--short", "HEAD" | ||
| standardOutput = outputStream | ||
| } | ||
| sha = outputStream.toString().trim() | ||
| } | ||
| def build_time = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss").format(new Date ()) | ||
| def text = """ | ||
| // Auto generated by gradle | ||
|
|
||
| package com.defold.extender; | ||
| public class Version { | ||
| public static final String gitVersion = "${sha}"; | ||
| public static final String buildTime = "${build_time}"; | ||
| } | ||
| """ | ||
| def binding = ["sha" : sha, "build_time" : build_time] | ||
|
|
||
| def engine = new groovy.text.SimpleTemplateEngine() | ||
| def template = engine.createTemplate(text).make(binding) | ||
|
|
||
| new File(projectDir.toString() + "/src/main/java/com/defold/extender", "Version.java").text = template.toString() |
There was a problem hiding this comment.
What was the benefit of this as opposed to the python script?
There was a problem hiding this comment.
I was debating wether to change this or not. Removing the python script drops a dependency on python in favour of Java.
client/src/main/java/com/defold/extender/client/ExtenderClient.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/defold/extender/client/ExtenderClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds asynchronous build support via the
/build_async/PLATFORM/VERSIONendpoint. Async builds return a job id which can be used to query build status via the/job_status?jobId=JOBIDendpoint while the build is in progress. When a build has completed the build result can be retrieved through the/job_result&jobId=JOBIDendpoint.