Update Android SDK (33.0.1 - Android 13 - API 33) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
approved these changes
Jan 15, 2023
server/docker-base/Dockerfile
Outdated
| ENV PATH ${PATH}:${ANDROID_NDK20_BIN_PATH} | ||
|
|
||
| # | ||
| # New NDK25b: |
There was a problem hiding this comment.
It's usually good to put the version of Defold where it's effectively in (so in this case 1.4.2)
That way it's easier for us to remove old stuff after 6 months.
There was a problem hiding this comment.
I'm going to merge it into the next version (after 1.4.2)
so, I'll add it before merge when I know the next version number
server/docker-base/Dockerfile
Outdated
| @@ -284,6 +340,7 @@ RUN \ | |||
| chmod +r -R ${ANDROID_ROOT} && \ | |||
| chmod +w -R ${ANDROID_SDK_ROOT} && \ | |||
| chmod -R 755 ${ANDROID_ROOT}/android-ndk-r${ANDROID_NDK20_VERSION} && \ | |||
| chmod -R 755 ${ANDROID_ROOT}/android-ndk-r${ANDROID_NDK25_VERSION} && \ | |||
| # check that dx installed properly | |||
There was a problem hiding this comment.
Perhaps want something similar for ndk25 ?
AGulev
commented
Jan 16, 2023
| #cleanup | ||
| rm -rf ${ANDROID_HOME}/extras && \ |
There was a problem hiding this comment.
Save about %50 size of the SDK
|
@JCash now PR has only Android SDK update, without NDK fixes. You can take a look this more clean PR |
JCash
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.