Added support for XCode 14.2, iOS 16.2 and macOS 13.1 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGulev
reviewed
Mar 17, 2023
| env.put("SYSROOT", "/opt/platformsdk/MacOSX11.3.sdk"); | ||
| env.put("MACOS_13_VERSION", "13.1"); | ||
| env.put("XCODE_14_CLANG_VERSION", "14.0.0"); | ||
| env.put("SWIFT_5_5_VERSION", "5.5"); |
There was a problem hiding this comment.
is it swift 5.5 not 5.7? https://developer.apple.com/documentation/xcode-release-notes/xcode-14_2-release-notes
There was a problem hiding this comment.
It's a folder name. There is no "swift-5.7" in Xcode. Only "swift", "swift-5.0" and "swift-5.5"
britzl
reviewed
Mar 17, 2023
| @@ -472,21 +472,18 @@ COPY template.local.properties ${EXTENSION_LOCAL_PROPERTIES_TEMPLATE} | |||
| # we still need to be able to resolve the variables in the case when we run the docker container locally when debugging | |||
|
|
|||
| # NOTE: These values are replicated in server/scripts/standalone/service-standalone.sh | |||
| # Install flow from >=1.2.174 | |||
AGulev
reviewed
Mar 17, 2023
| @@ -39,11 +33,22 @@ export XCODE_13_CLANG_VERSION=13.0.0 | |||
| export SWIFT_5_5_VERSION=5.5 | |||
| export IOS_VERSION_MIN=9.0 | |||
| export MACOS_VERSION_MIN=10.7 | |||
| export LIB_TAPI_1_6_PATH=/usr/local/tapi1.6/lib | |||
There was a problem hiding this comment.
Do we really use it somewhere? I thought it's something we use like alternative to the official (xcode) tool chain on linux?
There was a problem hiding this comment.
No, we don't use it per se, but there are some old sdks (build.yml) that still reference it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.