Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cocoapods issues #269

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Fix cocoapods issues #269

merged 4 commits into from
Mar 27, 2023

Conversation

ekharkunov
Copy link
Contributor

There were two issues that I found during cocoapods integration testing:

  1. When command pod spec cat --regex ... produce some additional output like
Ignoring ffi-1.15.4 because its extensions are not built. Try: gem pristine ffi --version 1.15.4

build failed with exception.
2. If pod spec has vendored_frameworks section under platform section - it ignores and produces linker error later. For example, UnityAds pod has following spec

{
  "name": "UnityAds",
  "version": "4.2.1",
  "license": {
    "type": "Unity License",
    "file": "LICENSE"
  },
  "authors": {
    "UnityAds": "itunes@unity3d.com"
  },
  "homepage": "https://unity3d.com/services/ads",
  "summary": "Monetize your entire player base and reach new audiences with video ads.",
  "platforms": {
    "ios": "9.0"
  },
  "source": {
    "http": "https://github.com/Unity-Technologies/unity-ads-ios/releases/download/4.2.1/UnityAds.zip"
  },
  "ios": {
    "vendored_frameworks": "UnityAds.xcframework"
  }
}

Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@britzl britzl merged commit 5297f1a into defold:dev Mar 27, 2023
@ekharkunov ekharkunov deleted the fix-cocoapods-issues branch January 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants