Changes for Emscripten update (3.1.55). #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resave assets. Replace json.lua with builtin json implementation.
ekharkunov
commented
Apr 10, 2024
| // Do early initialization of FBInstant | ||
| // This is required to be able to properly update the loading | ||
| // progress above. | ||
| FBInstant.initializeAsync().then(function() { | ||
| // This will be checked by the FBInstant Defold extension | ||
| Module._fbinstant_inited = true; | ||
| // Set up a progress listener and feed progress to FBInstant | ||
| ProgressUpdater.addListener(function (percentage) { |
There was a problem hiding this comment.
Use new ProgressUpdate from reworked dmloader.js. Also moved into initializeAsync callback to avoid FBInstant not defined error.
AGulev
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resave assets.
Replace json.lua with builtin json implementation.
Relates to defold/defold#6259