Changed rotation to CW to match regular Bob behaviour #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
commented
Apr 27, 2024
| @@ -84,7 +84,7 @@ | |||
| cw: clockwise rotation | |||
| ccw: counterclockwise rotation | |||
| The amount of rotation is always 90°. Only required for supportsRotation=true --> | |||
| <rotationDirection>ccw</rotationDirection> | |||
| <rotationDirection>cw</rotationDirection> | |||
There was a problem hiding this comment.
By doing this, it matches the rest of the layout+code in Bob/Editor
|
|
||
| <!-- Exporter version --> | ||
| <version>1.0</version> | ||
| <version>1.1</version> |
There was a problem hiding this comment.
Currently, we have the version number in two places.
SHould investigate if we can get this number in the exporter script.
| out.rotated = srcSprite.getRotated(); | ||
| boolean rotated = srcSprite.getRotated(); | ||
|
|
||
| out.setName(srcSprite.getName()); |
Comment on lines
+199
to
+209
| // For legacy reasons, the other bob code wants it already rotated | ||
| if (rotated) | ||
| { | ||
| width = originalSize.getHeight(); | ||
| height = originalSize.getWidth(); | ||
| } | ||
| else | ||
| { | ||
| width = originalSize.getWidth(); | ||
| height = originalSize.getHeight(); | ||
| } |
There was a problem hiding this comment.
Another fix that highlights that we still have some more stuff to stream line to avoid extra confusion.
AGulev
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.