Issue 16: Added protocol as a connection parameter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britzl
approved these changes
Oct 31, 2020
| @@ -709,6 +712,13 @@ static dmExtension::Result OnUpdate(dmExtension::Params* params) | |||
| #if defined(__EMSCRIPTEN__) | |||
| conn->m_SSLSocket = dmSSLSocket::INVALID_SOCKET_HANDLE; | |||
|
|
|||
| if (conn->m_Protocol) { | |||
| EM_ASM({ | |||
There was a problem hiding this comment.
So this changes the sub-protocol for all active web sockets? Could that become a problem? Or is the sub-protocol only set when connecting?
There was a problem hiding this comment.
It might be an issue.
I couldn't really find how the defold-websocket solved this issue?
I now saw that it didn't.
According to the emscripten code itself, it seems to be a per-connection setting.
https://github.com/emscripten-core/emscripten/blob/fc67fbf94b6b815c619e75dfe59c84f3c81bf698/src/library_sockfs.js#L193-L230
(Which I think makes sense, since it's a header in the handshake request.
Another option would be to set it at the app initialization phase. But we could do that if we find it to be an actual issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.