pkp#5960 Fix Publication not set error

defstat · Jun 26, 2020 · 97c4ed7 · 97c4ed7
1 parent 82c3cef
commit 97c4ed7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/locale/en_US/manager.po b/locale/en_US/manager.po
@@ -1564,6 +1564,9 @@ msgstr "The provided filesize \"{$expected}\" and the actual filesize \"{$actual
 msgid "plugins.importexport.common.error.duplicateRevisionForSubmission"
 msgstr "The revision \"{$revisionId}\" for submission file \"{$fileId}\" would create a duplicate record"
 
+msgid "plugins.importexport.common.error.currentPublicationNullOrMissing"
+msgstr "The submission's current publication is missing"
+
 msgid "plugins.importexport.native.error.submissionFileImportFailed"
 msgstr "The submission file could not be imported"
 

diff --git a/plugins/importexport/native/filter/NativeXmlSubmissionFilter.inc.php b/plugins/importexport/native/filter/NativeXmlSubmissionFilter.inc.php
@@ -129,10 +129,12 @@ function handleChildElement($n, $submission) {
 			case 'publication':
 				$publication = $this->parsePublication($n, $submission);
 
-				$publications = $submission->getData('publications');
-				$publications[] = $publication[0];
-				$submission->setData('publications', $publications);
-
+				if ($publication) {
+					$publications = $submission->getData('publications');
+					$publications[] = $publication[0];
+					$submission->setData('publications', $publications);
+				}
+
 				break;
 			default:
 				$deployment = $this->getDeployment();