Fix for broken 'initialValue' handling in Deft.Promise::reduce()

This functionality was broken when issue #6 was resolved. Fixes #48
deftjs · Aug 14, 2012 · ed6ce38 · ed6ce38
1 parent 014140a
commit ed6ce38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/coffee/Deft/promise/Promise.coffee b/src/coffee/Deft/promise/Promise.coffee
@@ -175,6 +175,7 @@ Ext.define( 'Deft.promise.Promise',
 		Traditional reduce function, similar to `Array.reduce()`, that allows input to contain promises and/or values.
 		###
 		reduce: ( promisesOrValues, reduceFunction, initialValue ) ->
+			initialValueSpecified = arguments.length is 3
 			return @when( promisesOrValues ).then( 
 				success: ( promisesOrValues ) ->
 					# Wrap the reduce function with one that handles promises and then delegates to it.
@@ -188,7 +189,7 @@ Ext.define( 'Deft.promise.Promise',
 							)
 					]
 
-					if ( arguments.length is 3 )
+					if initialValueSpecified
 						reduceArguments.push( initialValue )
 
 					return @when( @reduceArray.apply( promisesOrValues, reduceArguments ) )

diff --git a/src/js/Deft/promise/Promise.js b/src/js/Deft/promise/Promise.js