Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors do not propagate on class creation #14

Closed
joshnesbitt opened this issue May 16, 2012 · 5 comments
Closed

Errors do not propagate on class creation #14

joshnesbitt opened this issue May 16, 2012 · 5 comments
Labels
bug duplicate fixed
Milestone
next patch (0.6.6)

Comments

@joshnesbitt
Copy link
Contributor

Hi,

When a class is created through the Deft.mixin.Controllable mixin, if the class creation fails a generic error is thrown. Would this not be more useful to provide information related to why the class creation failed?

For example if you configure a store but the proxy fails to create, it's difficult to debug the exact point of failure. I'm happy to provide a pul request to fix this issue, I just need to know whether this is a valid request.

Cheers,
Josh
@johnyanarella
Copy link
Member

Very valid. I got burned by this myself last week.

@joshnesbitt
Copy link
Contributor Author

I'll be submitting a pull request shortly.

@joshnesbitt
Copy link
Contributor Author

I think the preference on this should be to log the message that is currently being thrown, then re-throw the error again. Would you agree?

@johnyanarella
Copy link
Member

Agreed.

@joshnesbitt joshnesbitt mentioned this issue May 16, 2012
Closed
@johnyanarella
Copy link
Member

Scheduled for inclusion in v0.6.6.

johnyanarella pushed a commit that referenced this issue May 22, 2012
Controllable mixin should automatically Ext.require() referenced View…
e3f96d4 
… Controller classes

Introduced a new Class pre-processor for the `controller` annotation which conditionally calls `Ext.require()` for required classes and applies Controllable behavior whenever it detects the target class is includes the`Deft.mixin.Controllable` mix-in.
Now relying on Ext.Loader() to report some errors that were previously handled internally.
Removed `Deft.mixin.Controllable` test cases that are no longer applicable.
Refactored previous fix for #14 and #15 to align with the new Class pre-processor oriented architecture.

Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug duplicate fixed
Projects
None yet
Milestone
next patch (0.6.6)
Development

No branches or pull requests
2 participants
@joshnesbitt @johnyanarella