deepStrictEqual #17
deepStrictEqual #17
Conversation
|
Is this part of the upstream node assert module? |
|
yes, would it make more sense to just bring in the current assert module ? |
|
ok rebased it based on current node, from what I can tell some of the things changed, e.g. the message formatting, I will comment on the changes individually |
| }); | ||
| }); | ||
|
|
||
| test('assert - Make sure deepEqual doesn\'t loop forever on circular refs', function () { |
There was a problem hiding this comment.
this test I modified because instead of throwing an error it was just terminating early with the correct answer, seemed like an even more desirable property
|
Can we remove the commented out tests? Or should they be fixed? |
|
removed, we also should probably make the running of the node version of On Mon, May 9, 2016 at 10:14 PM Roman Shtylman notifications@github.com
|
|
@defunctzombie ok should be fixed, it's still failing because I can't run the saucelabs tests from my repo, should pass if you fork it to your own repo and rerun it |
|
closing in favor of #18 |
this adds assert.deepStrictEqual which does exactly what you'd think it would do