-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepStrictEqual #17
deepStrictEqual #17
Conversation
Is this part of the upstream node assert module? |
yes, would it make more sense to just bring in the current assert module ? |
ok rebased it based on current node, from what I can tell some of the things changed, e.g. the message formatting, I will comment on the changes individually |
}); | ||
}); | ||
|
||
test('assert - Make sure deepEqual doesn\'t loop forever on circular refs', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test I modified because instead of throwing an error it was just terminating early with the correct answer, seemed like an even more desirable property
Can we remove the commented out tests? Or should they be fixed? |
removed, we also should probably make the running of the node version of On Mon, May 9, 2016 at 10:14 PM Roman Shtylman notifications@github.com
|
@defunctzombie ok should be fixed, it's still failing because I can't run the saucelabs tests from my repo, should pass if you fork it to your own repo and rerun it |
closing in favor of #18 |
this adds assert.deepStrictEqual which does exactly what you'd think it would do