Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] upgrade to browserify 9.0.3 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] upgrade to browserify 9.0.3 #20

wants to merge 1 commit into from

Conversation

marcello3d
Copy link
Collaborator

  • update to new API
  • passes all tests except ‘routes’

@marcello3d
upgrade to browserify 9.0.3
a058e13 
- update to new API
- passes all tests except ‘routes’
@defunctzombie
Copy link
Owner

any thoughts on why failing?

@marcello3d
Copy link
Collaborator Author

No, I want you to look at it. Hence WIP and my comment about all tests except routes passing. :-)

@marcello3d
Copy link
Collaborator Author

The test failure is a browserify bug.

@defunctzombie made a reproducible test case: browserify/browserify#1171

@arathael
Copy link
Contributor

Have you managed to update browserify to latest version?

@theogravity
Copy link
Contributor

Tried latest, still no go

@defunctzombie
Copy link
Owner

What is the issue?

On Saturday, September 5, 2015, Theo Gravity notifications@github.com
wrote:

Tried latest, still no go

—
Reply to this email directly or view it on GitHub
#20 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcello3d @defunctzombie @arathael @theogravity