This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Fix bug parsing chrome version string "30..latest" #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the travis tests failed. They passed locally for me. |
|
The tests will fail cause your branch doesn't have access to the saucelabs keys. I am not sure how to fix this so PRs stop failing. Maybe a Travis config. |
|
Oh well. What do you think about the actual change? It's simple enough :) |
|
Can we do something smarter? Like ignore anything that is not a number maybe? This seems like a very specific fix so if another word pops up we will need to patch that too. |
This fixes a bug where parsing the following browser field in .zuul.yml config fails: browsers: - name: chrome version: 35..latest Casting ‘beta’ to a number results in the end version being set to NaN.
|
@defunctzombie I was just matching what is already done in another place in this same file. See https://github.com/defunctzombie/zuul/blob/master/lib/flatten_browser.js#L72 But, I agree that it would be nice to do something smarter. I can update this PR to fix both uses. |
|
PR updated. |
defunctzombie
added a commit
that referenced
this pull request
Aug 7, 2014
Fix bug parsing chrome version string "30..latest"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where parsing the following browser field in .zuul.yml
config fails:
Casting ‘beta’ to a number results in the end version being set to NaN.