Standard lib FileUtils.mv takes a string or an array of strings as the src arg

[zenspider]

FileUtils.mv [file1, file2], dest

is perfectly legal. fakefs currently breaks in:

def mv(src, dest)
  if target = FileSystem.find(src)

as it isn't valid to pass an array as the arg to FileSystem.find. The error message is:

TypeError: can't convert Array into String
    project/tmp/isolate/ruby-1.8/gems/fakefs-0.2.1/lib/fakefs/file.rb:104:in `basename:'

[zenspider]

A further problem is that fakefs' FileUtils.mv seems to expect dest to be an inclusive path rather than either a renamed inclusive path or a directory to move the existing file to. The following method fixes both issues:

def mv(src, dest)
  Array(src).each do |path|
    if target = FileSystem.find(path)
      d_path = if File.directory? dest then
                 File.join dest, File.basename(path)
               else
                 dest
               end
      FileSystem.add(d_path, target.entry.clone)
      FileSystem.delete(path)
    else
      raise Errno::ENOENT, path
    end
  end
end

[smtlaissezfaire]

I'd gladly accept a patch if some tests were included :)

[gcampbell]

I've addressed these two issues (the array of files identified in the main issue #40, as well as directory destinations as mentioned in the comment above) as separate commits in http://github.com/gcampbell/fakefs/tree/40-mv-to-dir. The final result ends up looking pretty much like zenspider's code, except with a ternary instead of the if/else.

[wijet]

Could please merge gcambell's commits into master?

They work just fine with the latest master https://github.com/wijet/fakefs/tree/40-mv-to-dir

[gcampbell]

FileUtils.mv can now handle an array of sources

Closed by 4e9355d. Closed by 4e9355d