documented false as a allowed scrollTo value
#503
Conversation
| @@ -165,7 +165,7 @@ key | default | description | |||
| `replace` | false | replace URL without adding browser history entry | |||
| `maxCacheLength` | 20 | maximum cache size for previous container contents | |||
| `version` | | a string or function returning the current pjax version | |||
| `scrollTo` | 0 | vertical position to scroll to after navigation | |||
| `scrollTo` | 0 | vertical position to scroll to after navigation. `false` to disable scrolling. | |||
There was a problem hiding this comment.
Thanks. Can it say "false to not change scroll position"? Because we aren't really "disabling" scrolling.
There was a problem hiding this comment.
Something like: "To avoid changing scroll position, pass false."
|
@mislav fixed per feedback |
1 similar comment
|
@mislav fixed per feedback |
|
hmm seems like a github bug (double post and close) |
|
Looks great thanks. Can you remember what you did when you got double-post and closed by accident? Did you press the "Comment" button with mouse or used Cmd+Enter? I can try fixing the bug if you gave me more information about how to reproduce. |
documented `false` as a allowed `scrollTo` value
|
I did a ctrl+enter in firefox developer edition on win7x64 |
|
Thanks. Is there a chance you pressed Ctrl+Enter twice? |
|
Hm that might also be the case... |
|
I cannot reproduce this using Ctrl+Enter on Firefox on Windows. We disable
all form submit buttons upon first submit and until the form has finished
posting so that double submits are prevented. I can't imagine how it
happened that it closed the PR for you.
|
|
I am also unable to reproduce |
No description provided.