Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a simple parser instead of relying on regular expressions #39

Closed
wants to merge 1 commit into from

Conversation

holizz
Copy link

@holizz holizz commented Nov 27, 2011

From what I can tell, mustache isn't a regular language, so I made pystache parse a context-free language.

This closes issue #36.

@holizz
Copy link
Author

holizz commented Nov 28, 2011

On trying to use this with actual data, the performance turns out to be abysmal. I will close this and open another when it's not useless.

@holizz holizz closed this Nov 28, 2011
@cjerdonek
Copy link
Collaborator

Thanks for taking a crack at this. Do you have any idea how the speed of what you did compares to the speed of the version of the parser at the HEAD of the spec-compliant branch? If possible, would you be able to compare using the same test data you used before? Superficially, it looks like they might take a similar approach.

I'm also interested in seeing how the HEAD of the spec-compliant branch compares with what we have now in the master/development branches -- to inform whether we should bring it in. Thanks if you can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants