Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode Compatibility Tests #63

Closed
defuse opened this issue Feb 9, 2016 · 1 comment
Closed

Unicode Compatibility Tests #63

defuse opened this issue Feb 9, 2016 · 1 comment
Labels
Compatibility Branch SECURITY

Comments

@defuse
Copy link
Owner

defuse commented Feb 9, 2016

Test that the implementations are compatible with each other for strings containing non-ASCII characters. This will help with #31 since it gives evidence that the strings are being encoded into bytes the same way across all the implementations.
@defuse defuse added the SECURITY label Feb 9, 2016
@defuse defuse mentioned this issue Feb 10, 2016
Closed
@defuse
Copy link
Owner Author

defuse commented Feb 10, 2016

Done. I added a smiley face to tests/phpHashMaker.php. All implementations are correctly encoding to UTF-8 before hashing.

@defuse defuse closed this as completed Feb 10, 2016
@defuse defuse mentioned this issue Feb 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility Branch SECURITY
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@defuse