Skip to content

Commit

Permalink
Keep the mbstring test, but only for php <= 5.6, so it runs on CI
Browse files Browse the repository at this point in the history
  • Loading branch information
defuse committed Dec 17, 2019
1 parent fc8aae1 commit 75a00b1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/phpunit.sh
Expand Up @@ -67,7 +67,9 @@ if [ $? -eq 0 ]; then
php -d mbstring.func_overload=0 phpunit.phar $COVERAGE1_ARGS --bootstrap "$parentdir/$1" "$parentdir/test/unit" && \
# Run the test suite again with funky func_overload.
# This is deprecated in PHP 7 and PHPUnit is no longer compatible with the options.
# php -d mbstring.func_overload=7 phpunit.phar $COVERAGE2_ARGS --bootstrap "$parentdir/$1" "$parentdir/test/unit"
if [[ $PHP_VERSION -le 50600 ]]; then
php -d mbstring.func_overload=7 phpunit.phar $COVERAGE2_ARGS --bootstrap "$parentdir/$1" "$parentdir/test/unit"
fi
EXITCODE=$?
# Cleanup
if [ "$clean" -eq 1 ]; then
Expand Down

0 comments on commit 75a00b1

Please sign in to comment.