New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payment profiles support #10
Conversation
Other sources don't need to store these on Komoju for now, so just don't do anything for them.
This seems to be expected.
We're not using these but they are expected on credit cards, so better to have them.
This is important because in activemerchant we check if the payment is a CreditCard.
Until activemerchant/active_merchant#1941 is merged, we'll need to just include this here.
I've included the komoju gateway from activemerchant here, which overrides anything in that gem and thus enables us to use payment profiles. Once AM merges the change we can remove this and just reference the latest version of the gem. |
@camelmasa can you check this? I think you're in the best position to do that. |
@shioyama sure, I'll do that after lunch 🍖 |
@camelmasa can I merge this? |
@shioyama I was displayed following after confirm page . Please check it 💃 |
Thanks! I'll check that now. |
@shioyama But, I tried that twice. I succeed that :( |
This won't work for other payment methods that don't have that method. |
@camelmasa I added the missing credit card spec, have a look. |
@camelmasa Ah wait I'll add one for |
Ok everything is spec'ed now, have a look 😄 |
@shioyama Tnank you for implementation. Please rename |
@camelmasa done! |
@shioyama LGTM 💯 |
This depends on activemerchant/active_merchant#1941, so we can't actually merge it until that PR is merged.