Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cocoapods support #4

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Add Cocoapods support #4

merged 2 commits into from
Nov 15, 2019

Conversation

davbeck
Copy link
Contributor

@davbeck davbeck commented Nov 14, 2019

As the maintainer, you will probably want to submit this to the spec repo yourself (https://guides.cocoapods.org/making/making-a-cocoapod.html), but this will at least allow users to use the library using a manual git link: pod 'CodableCSV', git: 'https://github.com/dehesa/CodableCSV.git'.

@dehesa
Copy link
Owner

dehesa commented Nov 14, 2019

Hi David,

Thank you for the PR. I am not a user of Cocoapods, so I don't really know how it works. I will check it out tomorrow.

For what I am seeing the .podspec seems to be the "source of truth" and the version number is not picked from git tags (as with SPM) but from the spec, right? Your PR indicates the latest version as 0.2.0 and currently the repo is in 0.3.0

@davbeck
Copy link
Contributor Author

davbeck commented Nov 14, 2019

It's a little funny. There is a version in the podspec, as well as a pointer to the location of the source code (s.source). A very common setup is to point that at the tag matching the version in the spec, which is what I've done here. So if you submitted that spec as is, it would pull the 0.2.0 tag.

That should be changed to whatever the latest version is. I think it was 0.2.0 when I forked the project.

@dehesa
Copy link
Owner

dehesa commented Nov 15, 2019

Your PR seems good. Thank you!

Interestingly, I went to cocoapods.org to check if someone already uploaded the framework and there is another package called CodableCSV 😀 It is not this framework and it is much much simple, but I wonder whether they will allow me to upload a package with the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants