Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 3.0.1 #17

Merged
merged 4 commits into from
Nov 15, 2016
Merged

Update to Swift 3.0.1 #17

merged 4 commits into from
Nov 15, 2016

Conversation

sirnacnud
Copy link
Contributor

No description provided.

@dehli
Copy link
Owner

dehli commented Nov 10, 2016

Hey @sirnacnud, thanks for the PR! For some reason travis is failing even with your second commit. I'll try to look into it this this evening.

@sirnacnud
Copy link
Contributor Author

It looks like xctool doesn't support building with Xcode 8 and travis needs to usexcodebuild instead, see here.

@sirnacnud
Copy link
Contributor Author

sirnacnud commented Nov 10, 2016

I think the reason why it is still failing is because travis is using Xcode 8.0 instead of Xcode 8.1. Swift 3.0.1 was introduced in Xcode 8.1. We have to wait until they add support for Xcode 8.1, details here.

@dehli
Copy link
Owner

dehli commented Nov 15, 2016

Hey @sirnacnud, I actually saw the sneakpeek last night and was going to try it out today :) You beat me! Thanks!

@sirnacnud
Copy link
Contributor Author

sirnacnud commented Nov 15, 2016

Looks like the sneakpeak worked fine. When the 8.1 image is rolled out, the travis.yml will need to be updated back to xcode8, as 8.1 will be replacing 8.0.

@dehli
Copy link
Owner

dehli commented Nov 15, 2016

I'll go ahead and merge this, and then release a new pod version. Will update this thread once that is all done! Thanks again!

@dehli dehli merged commit f078bed into dehli:master Nov 15, 2016
@sirnacnud
Copy link
Contributor Author

I actually have another PR that you will probably want to include in the new pod version, I'm opening it shortly.

@sirnacnud sirnacnud deleted the swift-3 branch November 15, 2016 14:13
@dehli
Copy link
Owner

dehli commented Nov 15, 2016

Awesome! I'll make sure to hold off then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants