Week Two Assignment #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianyoung
reviewed
Aug 29, 2022
|
|
||
|
|
||
| local = { | ||
| "ops": {"get_s3_data": {"config": {"s3_key": "prefix/stock.csv"}}}, | ||
| "ops": {"get_s3_data": {"config": {"s3_key": "week_2/data/stock.csv"}}}, |
There was a problem hiding this comment.
Was this something you needed to change to get things working? I was slightly confused by the prefix path but for some reason I never needed to change it.
ianyoung
reviewed
Aug 29, 2022
| @op( | ||
| ins={"highest_stock": In(dagster_type=Aggregation)}, | ||
| required_resource_keys={"redis"}, | ||
| description="Store the highest value stock." |
There was a problem hiding this comment.
I included an out attribute of Nothing here. No idea if it's better to be explicit or not.
out=Out(dagster_type=Nothing),
ianyoung
reviewed
Aug 29, 2022
| def s3_resource(): | ||
| @resource( | ||
| config_schema={ | ||
| "bucket": str, |
There was a problem hiding this comment.
Also possible to use a Field() instead of bare types. Can be useful if you ever need to set a default or description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.