Week 3 Project Submission #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjw868
reviewed
Sep 4, 2022
week_3/project/week_3.py
Outdated
| yield RunRequest( | ||
| run_key=new_file, | ||
| run_config={ | ||
| "resources": {**docker["resources"]}, |
We can copy the full config settings and override only the relevant parts.
OrenLederman
approved these changes
Sep 5, 2022
week_3/project/week_3.py
Outdated
|
|
||
| docker_week_3_schedule = None # Add your schedule | ||
| # Schedule for docker: Start of every hour | ||
| docker_week_3_schedule = ScheduleDefinition(job=docker_week_3_pipeline, cron_schedule="0 * * * *") |
There was a problem hiding this comment.
The code passes the tests, but I believe this definition is incorrect. Try to turn o this schedule in Dagit, and it will compain about incorrect configuration. See this discussion - https://data-orchestration.slack.com/archives/C03SB6TAXQV/p1661960430498179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Confirmed all tests passing.