Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP stapling file is updated after hooks are called #513

Closed
NotActuallyTerry opened this issue Mar 17, 2018 · 2 comments
Closed

OCSP stapling file is updated after hooks are called #513

NotActuallyTerry opened this issue Mar 17, 2018 · 2 comments

Comments

@NotActuallyTerry
Copy link
Contributor

With OCSP_FETCH="yes", the code responsible for fetching the OCSP response is run after the deploy_cert & unchanged_cert hooks are called. This makes it impossible to update the stapling files for haproxy & other webservers that require the file to be named in a specific way.

Perhaps one way of solving it could be calling a new hook ocsp_update whenever the response is updated:
[[ -n "${HOOK}" ]] && "${HOOK}" "ocsp_update" "${domain}" "${certdir}/ocsp.der"

@lukas2511 lukas2511 added this to the Release 0.6.2 milestone Mar 17, 2018
lukas2511 pushed a commit that referenced this issue Apr 8, 2018
In relation to issue #513
@lukas2511
Copy link
Member

I merged your pull-request but extended it in 8ba56a8. Basically renamed the hook to deploy_ocsp (to be similar to deploy_cert) and exported altnames for use inside the hook. Thanks for the suggestion and the initial pull-request!

@zhangyoufu
Copy link

If I understand correctly, deploy_ocsp hook should be responsible for triggering cert/key/ocsp reload, and deploy_cert hook should not be used. Just in case a certificate was issued successfully, while fetching ocsp failed. A new cert should not be used in conjunction with old ocsp.der.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants