Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder should also support password callback #331

Open
smothiki opened this issue May 11, 2016 · 2 comments
Open

builder should also support password callback #331

smothiki opened this issue May 11, 2016 · 2 comments

Comments

@smothiki
Copy link
Contributor

Right now we are just using password callback in tests, it would be nice to support password call back , keeping in mind stand alone builder work.

@bacongobbler
Copy link
Member

bacongobbler commented Oct 31, 2016

I don't think this is something we want to allow. In a multi-tenant environment everyone should not have access to the git user's password, as there is no way we can authenticate who is pushing the build in the controller.

Keeping this open for discussion but I believe we should only allow keys. Much easier to allow/reject than changing a global password on a public PaaS.

@Cryptophobia
Copy link

This issue was moved to teamhephy/builder#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants