Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on github.com/deis/pkg/time #4

Closed
arschles opened this issue Jun 15, 2016 · 3 comments
Closed

Remove dependency on github.com/deis/pkg/time #4

arschles opened this issue Jun 15, 2016 · 3 comments
Assignees

Comments

@arschles
Copy link
Member

I believe github.com/deis/pkg/time is only used in one place - for time formatting between the server and the client. However, this package comes with dependencies on k8s.io/kubernetes/pkg/..., which is huge. This issue is for removing the dependency altogether, so that we don't have to pull in a 100MB+ (iirc) dependency to get 1 constant

@bacongobbler
Copy link
Member

I believe github.com/deis/pkg/time is only used in one place - for time formatting between the server and the client.

you are correct, sir. 🎩

@Joshua-Anderson
Copy link
Contributor

I'll take a look into this after I finish migrating the CLI to use the SDK!

@Joshua-Anderson
Copy link
Contributor

It seems like the best short term fix is to copy it into the sdk, so I did that in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants