New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(bundle/*): replace mapstructure tags with yaml tags #95
ref(bundle/*): replace mapstructure tags with yaml tags #95
Conversation
Do we need the YAML? The spec only really supports JSON for the bundle metadata right? Is this for downstream use by Porter? |
It's true, an argument can be made that Definitely open to suggestions on other routes to achieve the same goal of third-party consumers wishing to re-use these canonical golang structs but may be unmarshaling from representations other than JSON. |
b2b3c7a
to
cac56cd
Compare
I'm fine with adding the YAML, it makes things more flexible for downstream consumers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with adding YAML too, LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If we ever need to revisit the decision to support YAML tags, we might want to try converting from YAML to JSON and then reusing the JSON tags for demarshalling as in this article. |
Represents a possible dual closing of #91 and adding yaml tags to all of the structs (per recent history of third-party use in #90 and #92; 92 could/would be superseded by this PR.)