Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add new notation-validation sample policy #823

Merged
merged 2 commits into from
May 12, 2023

Conversation

byronchien
Copy link
Contributor

Description

What this PR does / why we need it:

This change adds a sample policy and constraint that matches the default notation validation behavior of "at least one signature must pass verification".

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

#819

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Signed-off-by: Byron Chien <byronc@ucla.edu>
@akashsinghal akashsinghal enabled auto-merge (squash) May 12, 2023 16:58
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3714f30) 53.57% compared to head (ee5a2b9) 53.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #823   +/-   ##
=======================================
  Coverage   53.57%   53.57%           
=======================================
  Files          62       62           
  Lines        3679     3679           
=======================================
  Hits         1971     1971           
  Misses       1500     1500           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akashsinghal akashsinghal merged commit 9a260cf into ratify-project:main May 12, 2023
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Byron Chien <byronc@ucla.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants