-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update-notation ref #940
chore!: update-notation ref #940
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 56.90% 56.90%
=======================================
Files 90 90
Lines 5272 5272
=======================================
Hits 3000 3000
Misses 1969 1969
Partials 303 303
☔ View full report in Codecov by Sentry. |
docs/archive/meeting-notes/ratify-weekly-notes-2022-Jan-2022-Jun.md
Outdated
Show resolved
Hide resolved
docs/archive/meeting-notes/ratify-weekly-notes-2022-Jul-2022-Dec.md
Outdated
Show resolved
Hide resolved
@yizha1 fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk @junczhu
The artifact type should be application/vnd.cncf.notary.signature
, not application/vnd.cncf.notary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @junczhu!
thanks for the PR @junczhu , the e2e is unblocked now. Could you help to resolve the conflict? |
Description
What this PR does / why we need it:
Update the references of Notation
Which issue(s) this PR fixes:
Fixes #703
Type of change
Please delete options that are not relevant.
verifier, notation-issuer-validation related
certs, signs
others (including policy, scripts, tests) & doc
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
go through CIs