Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update-notation ref #940

Merged

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Jul 20, 2023

Description
What this PR does / why we need it:
Update the references of Notation

Which issue(s) this PR fixes:
Fixes #703

Type of change
Please delete options that are not relevant.

verifier, notation-issuer-validation related
certs, signs
others (including policy, scripts, tests) & doc
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

go through CIs

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dc3785f) 56.90% compared to head (ca744cc) 56.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files          90       90           
  Lines        5272     5272           
=======================================
  Hits         3000     3000           
  Misses       1969     1969           
  Partials      303      303           
Files Changed Coverage Δ
cmd/ratify/main.go 25.00% <ø> (ø)
pkg/manager/manager.go 3.33% <ø> (ø)
pkg/verifier/notation/pluginmanager.go 65.38% <ø> (ø)
pkg/verifier/notation/truststore.go 85.00% <ø> (ø)
pkg/utils/certificateUtils.go 69.49% <100.00%> (ø)
pkg/verifier/notation/notation.go 86.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.vscode/launch.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@binbin-li
Copy link
Collaborator

@yizha1 fyi

Copy link
Collaborator

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk @junczhu

The artifact type should be application/vnd.cncf.notary.signature, not application/vnd.cncf.notary

pkg/policyprovider/configpolicy/configpolicy_test.go Outdated Show resolved Hide resolved
pkg/policyprovider/configpolicy/configpolicy_test.go Outdated Show resolved Hide resolved
pkg/policyprovider/configpolicy/configpolicy_test.go Outdated Show resolved Hide resolved
pkg/policyprovider/configpolicy/configpolicy_test.go Outdated Show resolved Hide resolved
pkg/policyprovider/configpolicy/configpolicy_test.go Outdated Show resolved Hide resolved
pkg/referrerstore/oras/oras_test.go Outdated Show resolved Hide resolved
pkg/referrerstore/oras/oras_test.go Outdated Show resolved Hide resolved
pkg/referrerstore/oras/oras_test.go Outdated Show resolved Hide resolved
pkg/referrerstore/oras/oras_test.go Outdated Show resolved Hide resolved
pkg/referrerstore/oras/oras_test.go Outdated Show resolved Hide resolved
@junczhu junczhu requested a review from yizha1 August 2, 2023 09:06
Copy link
Collaborator

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akashsinghal
akashsinghal previously approved these changes Aug 3, 2023
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @junczhu!

@junczhu junczhu changed the title chore: update-notation ref chore!: update-notation ref Aug 4, 2023
@susanshi
Copy link
Collaborator

susanshi commented Aug 4, 2023

thanks for the PR @junczhu , the e2e is unblocked now. Could you help to resolve the conflict?

@susanshi susanshi merged commit 908b2e5 into ratify-project:main Aug 8, 2023
15 checks passed
@junczhu junczhu deleted the update-notation-ref branch August 31, 2023 07:30
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references from Notary v2 to Notation
5 participants