Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to add arm64 binaries to the release job? #141

Closed
vdice opened this issue Dec 9, 2021 · 4 comments
Closed

Do we want to add arm64 binaries to the release job? #141

vdice opened this issue Dec 9, 2021 · 4 comments

Comments

@vdice
Copy link
Member

vdice commented Dec 9, 2021

Wondering if we want to add arm64 binaries to the release job? I'm personally interested in a linux arm64 binary, but I'd think we could also add darwin and win at the same time if we wanted.

Does anyone have experience using arm64-based GH action agents? Last I checked, there didn't appear to be any 'stock' arm64 agent flavors available... anyone have experience with https://github.com/marketplace/actions/run-on-architecture (Linux only)?

@radu-matei
Copy link
Member

I'm wondering if we could perhaps directly cross-compile Rust to ARM64 — https://www.rohanjain.in/cargo-cross
A few months ago I tested on an ARM64 Rasberry Pi, and I recall being able to cross compile to it from my AMD CPU.

Re: Darwin support, I don't see any activity on actions/runner-images#2187.
Perhaps @squillace might have some insight?

@vdice
Copy link
Member Author

vdice commented Jan 5, 2022

Another reference for cross-compilation, specifically via GH actions, which is what we want here: https://github.com/krustlet/krustlet/blob/a303840c1fd86f2e07f687be47a137be2ecfd326/.github/workflows/build.yml#L55-L68

Thanks for the link @bacongobbler. cc @adamreese

@vdice
Copy link
Member Author

vdice commented Feb 1, 2022

Linux aarch64 has been added.

Check out https://github.com/deislabs/bindle/blob/main/.github/workflows/release.yaml for a pattern on how to add Mac/Darwin aarch64.

@technosophos
Copy link
Contributor

Closing, now that we actually just shipped ARM support 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants