Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Rename allowed_domains and disable all by default #37

Closed
radu-matei opened this issue Mar 22, 2021 · 0 comments · Fixed by #39
Closed

Rename allowed_domains and disable all by default #37

radu-matei opened this issue Mar 22, 2021 · 0 comments · Fixed by #39
Assignees

Comments

@radu-matei
Copy link
Member

First of all, allowed_domains should actually be allowed_hosts, because the items can be IP addresses, not only domain names.

But more importantly, when passing None, the library currently allows guest modules to make requests to any server, which is counter-intuitive, and directly opposed to how any other capability works.

We should address both of these and release a new version to crates.io.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant