-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using multiple files, one per schema #70
Conversation
;; | ||
bzip2) | ||
COMPRESS="bzip2" | ||
UNCOMPRESS="bzip2 -d" | ||
EXTENSION="bz2" | ||
EXTENSION="tbz2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deitch may i ask why u changed this to "tbz2" ? a typo ? becasue the official extension is "bz2" 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Official extension is bz2
for bzipped files. What about tar bzipped files? I put in tbz2
like tgz
for tar gzipped files. Is there a different one for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, tbz2
seems the accepted extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this in. Can always update that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deitch i am a devop now for over 15 years and i have "never ever" seen the extension "tbz2" anywhere! there must be a reason for that 😂
and wikipedia does not mention that extension as well. so please, undo this to something everybody is used to know 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, both tb2
and tbz2
are commonly accepted, like tgz
(as, of course, are .tar.gz
and .tar.bz2
).
Open a new issue after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deitch about gzip: i can only say what i see out there in the wild: and as long as you don´t use tar, people use ".gz", if they use tar, the files mostly have ".tar.gz". even if "tgz" might be "not wrong", it´s always good to know, what people are dealing with. if i see a "tar.gz" i know, without looking into the file, that "tar" was used. if i see ".gz" i know it´s (properly) not packed by tar. developers are lazy, they use as less chars they need, so i guess there´s a reason why mostly ".gz" is used and not ".tgz" 😏
anyway: everything was fine, i don´t understand why there is a need for you to change that at all 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a need for you to change that at all
It isn't a gz
anymore, it is a tarred gzip file, so the extension needs to indicate it. For consistency, they are all tar-gz or tar-bz2, even single file.
if i see a "tar.gz" i know, without looking into the file, that "tar" was used. if i see ".gz" i know it´s (properly) not packed by tar.
exactly. If you saw bz2
, you would think it is a single compressed file, not a tarred file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deitch i didn´t recognize in your changes that "tar" is involved here, sorry. in that case, forget what i said. ironically most people tend to use the long version, they use "tar.gz" and "tar.bz2" - maybe it´s better readable, i don´t know, but that´s whats most commen used. would be happy if you could follow that "inofficial" standard 😏
9df1119
to
d8926fc
Compare
d8926fc
to
ada2a35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deitch i am a devop now for over 15 years and i have "never ever" seen the extension "tbz2" anywhere! there must be a reason for that 😂
and wikipedia does not mention that extension as well. so please, undo this to something everybody is used to know 😏
Fixes #64