Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame command doesn't work with negative number #136

Closed
ark6 opened this issue Apr 11, 2015 · 5 comments
Closed

frame command doesn't work with negative number #136

ark6 opened this issue Apr 11, 2015 · 5 comments

Comments

@ark6
Copy link
Contributor

ark6 commented Apr 11, 2015

GUIDE.md says that
when frame command is typed with negative number, outermost stack frame is shown.

However, in practice, nothing is displayed, and doesn't move to the frame I specify with the argument.
Is this a bug ?
(using ruby 2.2.1p85 and byebug 4.0.5.)

@deivid-rodriguez
Copy link
Owner

Bug/Feature doesn't matter, I'd like this to work as stated in the Guide.

Do you want to try a PR? It should be an easy one and I can help if necessary.

@ark6
Copy link
Contributor Author

ark6 commented Apr 11, 2015

Yes, I want to try it.

@deivid-rodriguez
Copy link
Owner

This is where the magic happens and where you'll probably need to apply the fix: https://github.com/deivid-rodriguez/byebug/blob/master/lib/byebug/helpers/frame.rb#L7-48

And this is where the command is implemented and calls those methods: https://github.com/deivid-rodriguez/byebug/blob/master/lib/byebug/commands/frame.rb#L29

Thanks!

@ark6
Copy link
Contributor Author

ark6 commented Apr 12, 2015

Thanks for the info.

deivid-rodriguez pushed a commit that referenced this issue Apr 12, 2015
@deivid-rodriguez
Copy link
Owner

Thanks a lot for your work @ark6, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants