Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you connect to a remote server, quitting won't quit #201

Closed
swrobel opened this issue Jan 13, 2016 · 8 comments
Closed

If you connect to a remote server, quitting won't quit #201

swrobel opened this issue Jan 13, 2016 · 8 comments

Comments

@swrobel
Copy link

swrobel commented Jan 13, 2016

ran byebug -R localhost:<PORT>

(byebug) quit
Really quit? (y/n) n

It still drops me back to a prompt

using gem 8.2.1
@deivid-rodriguez
Copy link
Owner

Sorry for getting late to this. I don't understand the issue. Can you elaborate?

@swrobel
Copy link
Author

swrobel commented May 12, 2016

I guess this is a better illustration, by a prompt I mean it keeps me in byebug:

(byebug) quit
Really quit? (y/n) y
(byebug)

@deivid-rodriguez
Copy link
Owner

Ok, now I need instructions or a sample repository to reproduce the issue.

@swrobel
Copy link
Author

swrobel commented May 12, 2016

Nevermind, I don't use it enough to bother to do that. Already spent 15 minutes reproducing. If you connect to a remote server, quitting won't quit. There you go.

@deivid-rodriguez
Copy link
Owner

Oook.

I'll leave the issue opened in case this bothers someone else who is more interested.

@deivid-rodriguez deivid-rodriguez changed the title Answering 'n' to 'Really quit?' still quits If you connect to a remote server, quitting won't quit (apparently) May 12, 2016
deivid-rodriguez pushed a commit that referenced this issue May 13, 2016
Don't confirm on the remote side
37c43a3 
Otherwise we are sending "true" or "false" instead of "y" / "n" through
the wire and confirmation on the client side fails.

Fixes #201.
@deivid-rodriguez deivid-rodriguez changed the title If you connect to a remote server, quitting won't quit (apparently) If you connect to a remote server, quitting won't quit May 13, 2016
@deivid-rodriguez
Copy link
Owner

@swrobel Finally reproduced and fixed this in #259, can you confirm?

@deivid-rodriguez deivid-rodriguez mentioned this issue May 13, 2016
Merged
@swrobel
Copy link
Author

swrobel commented May 13, 2016

Thank you, that works!

@deivid-rodriguez
Copy link
Owner

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swrobel @deivid-rodriguez