Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to get a line in eval context #263

Merged
merged 1 commit into from
May 14, 2016

Conversation

k0kubun
Copy link
Contributor

@k0kubun k0kubun commented May 14, 2016

Fix for test 2 and 3 in #194.

We can't open a file named "(eval)". So byebug should skip to read its line on linetrace.

@deivid-rodriguez
Copy link
Owner

@k0kubun Looks great. Just one nitpick, can you split the assertion into a different test? Oh, and can you add a change log entry?

@k0kubun k0kubun force-pushed the skip-eval branch 4 times, most recently from 5dfbc9f to 86c979f Compare May 14, 2016 15:44
@deivid-rodriguez
Copy link
Owner

Mmm, I meant to split the assertion to a separate method, not a separate class and file. I'm aiming at having one file in test/commands per command in lib/byebug/commands, that's why I prefer not to have this in a separate file and keep it in the test/commands/continue_test.rb file.

Also, the change log entry is missing a "### Fixed" entry and we need a rebase.

Sorry for the trouble...

@deivid-rodriguez deivid-rodriguez merged commit 3e33d2e into deivid-rodriguez:master May 14, 2016
@deivid-rodriguez
Copy link
Owner

Thank you very much @k0kubun!!

@k0kubun k0kubun deleted the skip-eval branch May 15, 2016 01:54
@k0kubun
Copy link
Contributor Author

k0kubun commented May 15, 2016

Thank you for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants