Fixup the testsuite fails on macOS #373
Conversation
|
It fails there with a new issue now. Will take a look into that. |
bak1an
force-pushed
the
macos_testsuite_fix
branch
from
8856aff
to
652fe31
Compare
|
Appveyor build fix went into #376 |
Default tmpdir on macOS is is a symlink pointing somewhere in `/private/...`. Because of this in the testsuite we should always use realpaths since byebug outputs those by default.
bak1an
force-pushed
the
macos_testsuite_fix
branch
from
652fe31
to
e09f4fe
Compare
|
Rebased that to include windows build fix |
|
Thanks @bak1an! I have another little request. I used to run Travis against both macOS and Linux in the past but I disabled it because macOS was hard to get passing and I didn't feel it was useful. However, most developers run macOS these days so it seems like a great thing to ensure that the tests pass in that environment. Can you try enabling Travis on macOS and see if it passes? Ref: https://docs.travis-ci.com/user/multi-os/. |
|
Makes sense @deivid-rodriguez Will try and see what happens. |
|
I'm going to merge this for now, we can take care of adding macOS to the CI in a separate PR! Thanks @bak1an!! |
|
Thanks @deivid-rodriguez! Most likely will spend time on macOS travis configuration next week. |
Default tmpdir on macOS is is a symlink pointing somewhere in
/private/.... Because of this in the testsuite we shouldalways use realpaths since byebug outputs those by default.
Without the fix it is full of failures like https://gist.github.com/bak1an/4f6bdbbadfe96c53bd9d16dd86a87779
The PR also disables
WhereWithNotDeeplyNestedPathsTestfordarwinsince default$TMPDIRon macOS nowadays is something like/var/folders/5g/s0v3cc2x34ddw3ydhyvkryvr0000gn/T/(which has realpath/private/var/folders/5g/s0v3cc2x34ddw3ydhyvkryvr0000gn/T/). This is the opposite ofnot deeply nestedand just fails.