Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing on macOS #508

Merged
merged 1 commit into from
Nov 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,22 +46,6 @@ abide by its terms.
* Byebug uses several style checks to check code style consistent. You can run
those using `bin/rake lint`.

### Runnning `clang-format` on macOS

At the moment byebug uses older `clang-format` version to enforce C codestyle than
can be found in Homebrew. If you are planning to change some C source here it is
recommended to use [direnv][] to hook that older version into your shell:

* Install [direnv][] as described in their README
* Install `clang-format@3.8` with `brew install clang-format@3.8`
* In byebug source code directory do `echo 'export PATH="/usr/local/opt/clang-format@3.8/bin:$PATH"' > .envrc`
* Allow direnv to use that `.envrc` file with `direnv allow`

With that your `$PATH` will be updated to use older `clang-format` every time you `cd`
into byebug source code folder. It will reverted back when you `cd` out of it as well.

[direnv]: https://github.com/direnv/direnv/

## Byebug as a C-extension

Byebug is a gem developed as a C-extension. The debugger internal's
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ while it executes and offers many of the traditional debugging features such as:
## Build Status

Linux [![Cir][cir]][cir_url]
macOS [![Tra][tra]][tra_url]
Windows [![Vey][vey]][vey_url]

[cir]: https://circleci.com/gh/deivid-rodriguez/byebug/tree/master.svg?style=svg
Expand Down
2 changes: 0 additions & 2 deletions test/remote_debugging_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ def program_with_two_breakpoints
end

def test_interrupting_client_doesnt_abort_server_after_a_second_breakpoint
skip("Failing on OSX") if RUBY_PLATFORM =~ /darwin/

write_program(program_with_two_breakpoints)

status = remote_debug_connect_and_interrupt("cont")
Expand Down