Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some exit codes #520

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Fix some exit codes #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b252261
Prefer rake's `sh` to `system`
deivid-rodriguez Dec 28, 2018
d81490c
Abort if a docker command fails
deivid-rodriguez Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ namespace :lint do
task :mdl do
puts "Running mdl"

abort unless system("mdl", *Dir.glob("*.md"))
sh("mdl", *Dir.glob("*.md"))
end

desc "Checks shell code style with shellcheck"
task :shellcheck do
puts "Running shellcheck"

abort unless system("shellcheck", *Dir.glob("bin/*.sh"))
sh("shellcheck", *Dir.glob("bin/*.sh"))
end
end

Expand Down Expand Up @@ -114,7 +114,8 @@ namespace :docker do
compiler: opts[:compiler]
)

manager.build && manager.push
manager.build
manager.push
end

desc "Test all docker images"
Expand Down
5 changes: 3 additions & 2 deletions docker/manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,10 @@ def run(*command)

puts(success ? "✔" : "❌")

puts output unless success
return if success

success
puts output
abort
end

private
Expand Down