Go back to a full require for requiring the extension
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes byebug usage in Fedora. Fedora's rubygems uses a switch to prevent compiled extensions from being installed into each gem's lib/ directory (`Gem.install_extension_in_lib = false`). So byebug doesn't properly work there. Going back to a require fixes the issue.
deivid-rodriguez
force-pushed
the
fix/bad_require
branch
from
cabe644
to
5c2e3f2
Compare
|
Thanks to @jorge-barreto for reporting this issue! 💜 |
|
Thank you for fixing this so quickly! Just stumbled upon this issue and you already fixed this ❤️ |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 5, 2020
Update ruby-byebug to 11.1.1. ## [11.1.1] - 2020-01-24 ### Fixed * [#635](deivid-rodriguez/byebug#635): usage on Fedora 31 or any other `byebug` installation performed by a `rubygems` copy customized by setting `Gem.install_extension_in_lib` to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes byebug usage in Fedora. Fedora's rubygems uses a switch to prevent compiled extensions from being installed into each gem's lib/ directory (
Gem.install_extension_in_lib = false). So byebug doesn't properly work there.Going back to a require fixes the issue.