Fast-slow encoder rotation increments #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet please, I made an error testing this build. NUM_DIFF was too low, so it didn't detect the fast rotation of the encoder. |
|
Ready to merge, please review/test before merging. Time_diff value might be too low or too high, in KSGER t12 v3 it's good. If it's too sensitive, increase it. I left it at 57 |
There is a change in time_diff when the station is powered and working, so 57ms is too low of a value, changed it to 80ms. Station seems to change sensitivity when powered to outlet, so 80 ms seems a better value.
|
Changed time_diff to 80 again. |
|
Ensure to test it properly! Will wait a bit more... |
Sure, thanks. |
|
As you added better support for it, pr will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the eevblog user "ygi" suggested, this is a pull request to add the fast-slow temperature increments.