Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.1 Support #191

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

JuanVqz
Copy link
Contributor

@JuanVqz JuanVqz commented Oct 6, 2023

The railties dependency was blocking compatibility with a new version,
after allowing it should be fine.

Fixes #180

The railties dependency was blocking compatibility with a new version,
after allowing it should be fine.

Fixes dejan#180
@JuanVqz JuanVqz changed the title Add support to Rails 7.1 Add Rails 7.1 Support Oct 6, 2023
@JuanVqz
Copy link
Contributor Author

JuanVqz commented Oct 6, 2023

I just tested it in a brand-new app, It worked like a charm 🥳

Screenshot 2023-10-06 at 17 54 04

@botsarenthuman
Copy link

Needs to update the railties support for 7.1.1

Could not find compatible versions

Because every version of meta_request depends on railties >= 3.0.0, <= 7.1
  and rails >= 7.1.1 depends on railties = 7.1.1,
  every version of meta_request is incompatible with rails >= 7.1.1.
So, because Gemfile depends on rails ~> 7.1.1
  and Gemfile depends on meta_request >= 0,
  version solving has failed

@Roguelazer
Copy link

I opened #192 to do this and also add tests, fwiw

@JuanVqz
Copy link
Contributor Author

JuanVqz commented Oct 16, 2023

Well, it seems like I don't need to update anything, Roguelazer already covered it

@stefannibrasil
Copy link

+1

@dejan dejan merged commit 9304428 into dejan:master Apr 12, 2024
@dejan
Copy link
Owner

dejan commented Apr 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Rails 7
5 participants