Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark project as deprecated #41

Merged
merged 3 commits into from
Aug 2, 2016
Merged

Mark project as deprecated #41

merged 3 commits into from
Aug 2, 2016

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 19, 2016

No description provided.

@staabm staabm changed the title Update README.md Mark project as deprecated Jun 19, 2016
@staabm
Copy link
Contributor Author

staabm commented Jun 19, 2016

It looks like you can even define a suggested replacement for this package on packagist.
At best someone with permissions todo so would make this also point to stomp-php/stomp-php.

@@ -1,6 +1,7 @@
{
"name": "fusesource/stomp-php",
"description": "stomp support for PHP",
"abandoned": true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the abandoned flag contained in the composer schema?
I thought it's only controlled by the packagist project homepage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this composer/composer@320533b which made me feel it is

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good, didn't see this the last time I was looking for a way to setup a proper abandoned handling.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abandon flag seems to be only available for the satis configuration. I abandoned the Package in packagist and named stomp-php/stomp-php as the follow up

@jmglsn
Copy link

jmglsn commented Jun 19, 2016

Our version 2 releases include the required tag to offer a replacement for "fusesource/stomp-php":"2.1.*".
https://github.com/stomp-php/stomp-php/blob/support/version-2/composer.json#L28

@staabm
Copy link
Contributor Author

staabm commented Jun 19, 2016

Should we define replace for this repos in version 3 & 4?

@jmglsn
Copy link

jmglsn commented Jun 19, 2016

3 and 4 won't work as a real replacement, as the depending code would need to be changed, version 2 is still compatible.

@monofone monofone merged commit 2c20b62 into dejanb:master Aug 2, 2016
@staabm staabm deleted the patch-1 branch August 2, 2016 11:23
@staabm
Copy link
Contributor Author

staabm commented Aug 2, 2016

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants